Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.48%. Comparing base (f1388f9) to head (42011d1).

@@            Coverage Diff             @@
##           master    #4084      +/-   ##
==========================================
+ Coverage   90.45%   90.48%   +0.03%     
==========================================
  Files         941      942       +1     
  Lines       60390    60402      +12     
  Branches     1145     1145              
==========================================
+ Hits        54628    54657      +29     
+ Misses       5252     5238      -14     
+ Partials      510      507       -3     

The fix seems reasonable at first glance, but we do a lot of these gears.table.crush in our constructor-functions. There should be a lot of other properties wrongly copied this way in many modules. Applying this rawset to remove them afterward would just not be maintainable.

A better solution would be to basically refactor the module pattern we use and clearly separate the module level from instance level stuff. I'm currently experimenting Teal. The type system it brings would help a lot in this scenario. The big migration, in addition to being a massive work would probably be not welcomed considering the current status of the project.

The fix seems reasonable at first glance, but we do a lot of these gears.table.crush in our constructor-functions. There should be a lot of other properties wrongly copied this way in many modules. Applying this rawset to remove them afterward would just not be maintainable.

A better solution would be to basically refactor the module pattern we use and clearly separate the module level from instance level stuff. I'm currently experimenting Teal. The type system it brings would help a lot in this scenario. The big migration, in addition to being a massive work would probably be not welcomed considering the current status of the project.

It’s true—it would be much better if the language supported object-oriented programming.
I’ve used Penlight’s class before, but they weren’t ideal either.

@Aire-One So how should we fix this?